From: Florian Müllner <fmuellner@gnome.org>
Date: Wed, 9 Sep 2020 18:51:53 +0000 (+0200)
Subject: st/entry: Only handle primary/secondary icon clicks when reactive
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~655^2^2~28
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=76b03647b3c10f23f5ff9479d2772a727b2383eb;p=gnome-shell.git

st/entry: Only handle primary/secondary icon clicks when reactive

Just like the internal ClutterText, the icon actors are part of the
entry. It therefore makes sense for the icons to not react to clicks
when the entry itself is non-reactive; again, just like the text.

That behavior is also consistent with icons in GTK entries.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3138
---

diff --git a/src/st/st-entry.c b/src/st/st-entry.c
index fdf0168c9..043be6a7c 100644
--- a/src/st/st-entry.c
+++ b/src/st/st-entry.c
@@ -1312,6 +1312,9 @@ _st_entry_icon_clicked_cb (ClutterClickAction *action,
 {
   StEntryPrivate *priv = ST_ENTRY_PRIV (entry);
 
+  if (!clutter_actor_get_reactive (CLUTTER_ACTOR (entry)))
+    return;
+
   if (actor == priv->primary_icon)
     g_signal_emit (entry, entry_signals[PRIMARY_ICON_CLICKED], 0);
   else